build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )
Change subject: drivers/spi/winbond: Add function to lock flash's status register ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@544 PS2, Line 544: const enum spi_flash_status_reg_lockdown mode, code indent should use tabs where possible
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@545 PS2, Line 545: const bool non_volatile) code indent should use tabs where possible
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@559 PS2, Line 559: val = (union status_reg1_bp3){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@560 PS2, Line 560: mask = (union status_reg1_bp3){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@562 PS2, Line 562: val = (union status_reg1_bp4){ .srp0 = !!(mode & 1) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@563 PS2, Line 563: mask = (union status_reg1_bp4){ .srp0 = 1 }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@570 PS2, Line 570: val = (union status_reg2){ .srp1 = !!(mode & 2) }.u; space required after that close brace '}'
https://review.coreboot.org/#/c/28697/2/src/drivers/spi/winbond.c@571 PS2, Line 571: mask = (union status_reg2){ .srp1 = 1 }.u; space required after that close brace '}'