EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38526 )
Change subject: ec/google/wilco: add ec command set cpu id
......................................................................
Patch Set 4:
Patch Set 4:
(2 comments)
Just minor style notes.
Are you planning to call this from wilco_ec_init() or from the mainboard/soc code?
If there no common way to get cpu cores, I will put into board level. I am checking with Intel. If we can get cpu cores from command, we can put into wilco_ec_init.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38526
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I135d2421d2106934be996a1780786f6bb0bf6b34
Gerrit-Change-Number: 38526
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jan 2020 02:32:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment