Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40020 )
Change subject: sb/intel/bd82x6x: Tidy up code and comments ......................................................................
Patch Set 1:
(2 comments)
Thank you for cleaning this up.
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 56: .read_byte = lsmbus_read_byte, Why not stay with tabs?
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/usb_ehci.c:
https://review.coreboot.org/c/coreboot/+/40020/1/src/southbridge/intel/bd82x... PS1, Line 98: .scan_bus = NULL, Why not `DEVICE_NOOP`?