build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )
Change subject: security/intel/stm: Add STM support ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c File src/security/intel/stm/SmmStm.c:
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@439 PS6, Line 439: for (SubIndex = 0; suspect code indent for conditional statements (24, 24)
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@442 PS6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > line over 80 characters
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@442 PS6, Line 442: if ((Resource->PciCfg.PciDevicePath[SubIndex].PciDevice > suspect code indent for conditional statements (24, 40)
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@444 PS6, Line 444: (Resource->PciCfg.PciDevicePath[SubIndex].PciFunction > line over 80 characters
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@748 PS6, Line 748: (STM_PAGES_TO_SIZE(STM_SIZE_TO_PAGES(StmHeader->SwStmHdr.StaticImageSize)) line over 80 characters
https://review.coreboot.org/#/c/33234/6/src/security/intel/stm/SmmStm.c@750 PS6, Line 750: + (StmHeader->SwStmHdr.PerProcDynamicMemorySize trailing whitespace