Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32042 )
Change subject: console/kconfig: Move ONBOARD_VGA_IS_PRIMARY to 'devices'
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32042/1/src/device/Kconfig
File src/device/Kconfig:
https://review.coreboot.org/#/c/32042/1/src/device/Kconfig@694
PS1, Line 694: else the onboard adapter is used.
Btw is meaningful on non-x86?
Yes, on PowerPC for sure, I guess OpenPower too. Generally it's
technically possible for anything with port i/o and PCI. Not sure
if we have a Kconfig flag for the former.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32042
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I039f4f6bbe144769d6a362192b225838ed3d9d43
Gerrit-Change-Number: 32042
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 25 Mar 2019 15:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment