Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39869 )
Change subject: payloads/seabios: Add Hardware IRQ Kconfig ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39869/4/payloads/external/SeaBIOS/K... File payloads/external/SeaBIOS/Kconfig:
https://review.coreboot.org/c/coreboot/+/39869/4/payloads/external/SeaBIOS/K... PS4, Line 60: This option should : be enabled for all platforms/boards except for those which require : it to be disabled.
Is this statement useful? […]
"If it needs to be disabled, disable it" feels a bit tautological indeed.
https://review.coreboot.org/c/coreboot/+/39869/4/src/mainboard/google/rambi/... File src/mainboard/google/rambi/Kconfig:
PS4:
What for?
There's two conflicting goals here: 1. make a change well-isolated (so that we could revert rambi individually from the global HARDWARE_IRQ thing, for example), 2. don't add stuff to the tree that isn't used (e.g. having the HARDWARE_IRQ thing floating around without the rambi part merged for whatever reason)
IMNSHO for a change of this size it can go either way.