1 Jul
2020
1 Jul
'20
8:43 a.m.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38648 )
Change subject: util/cbfstool: extend includes in commonlib ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38648/3/src/commonlib/bsd/lz4_wrapp... File src/commonlib/bsd/lz4_wrapper.c:
https://review.coreboot.org/c/coreboot/+/38648/3/src/commonlib/bsd/lz4_wrapp... PS3, Line 5: sysincludes why not endian.h? Otherwise we'd have to put in the kitchen sink to cover all "sys includes" (as per Julius' proposal)
--
To view, visit https://review.coreboot.org/c/coreboot/+/38648
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd81c2a96c608589ce2ec8f4b883fd4e584776b1
Gerrit-Change-Number: 38648
Gerrit-PatchSet: 3
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Jul 2020 15:43:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment