Julius Werner has posted comments on this change. ( https://review.coreboot.org/28374 )
Change subject: mainboard/google/kahlee: Enable EC firmware update screen
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig
File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig@...
PS1, Line 101: if VBOOT_EC_SOFTWARE_SYNC
nit: VBOOT_EC_SLOW_UPDATE already has a 'depends on VBOOT_EC_SOFTWARE_SYNC', this if clause is pretty pointless.
--
To view, visit
https://review.coreboot.org/28374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95fc4d3430bac66c09f57a4d34abde08752e5f0e
Gerrit-Change-Number: 28374
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Aug 2018 22:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes