Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 54: VBOOT
No I didn't? Changed to VBOOT_STARTS_IN_BOOTBLOCK now though.
You are removing the _Static_assert() for that from https://review.coreboot.org/c/coreboot/+/46510/6/src/drivers/intel/fsp2_0/me... and I don't see it reappear anywhere else. If you're not intentionally removing that, you should move it to mrc_cache.c (but like I said I'm not really sure why we're mandating that).
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 55: n
Agree we should default y the future boards. Changed to reflect that for ChromeOS boards.
Not sure about the Chrome OS only part to be honest, I don't think this question has anything to do with Chrome OS. If we think this is a good thing to have for our boards, why shouldn't it be a good thing to have for other boards (that match the requirements)? Of course anyone can override it as they want (actually might be worth making this user-selectable in menuconfig... need to put a name string behind the 'bool' to do that), but by default I think if it's useful then it should be default-on everywhere. (Like you said it currently only affects TPM2 devices which are all Chrome OS right now, so we're not immediately affecting anyone else anyway.)