Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40379 )
Change subject: soc/intel/common/block/systemagent: Add choice option for PCIEX_LENGTH
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40379/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/40379/2/src/soc/intel/common/block/...
PS2, Line 12: config SA_PCIEX_LENGTH
: hex
: default 0x10000000 if (PCIEX_LENGTH_256MB)
: default 0x8000000 if (PCIEX_LENGTH_128MB)
: default 0x4000000 if (PCIEX_LENGTH_64MB)
: default 0x10000000
: help
: This option allows you to select length of PCIEX region.
Should this not be a Kconfig option any longer then?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40379
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb61e9a0263c058726cc07442af1985a96bf37c2
Gerrit-Change-Number: 40379
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 17:54:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
