Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38586 )
Change subject: superio/aspeed/ast2400: Add eSPI auto detection ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38586/2/src/superio/aspeed/ast2400/... File src/superio/aspeed/ast2400/superio.c:
https://review.coreboot.org/c/coreboot/+/38586/2/src/superio/aspeed/ast2400/... PS2, Line 38: 0x07
either this or the val == 0xc in line 41 is wrong; in the current state the condition below can't be […]
You are totally right. Sorry this is untested yet as I only have the chance to get my hands on real hardware tomorrow.
https://review.coreboot.org/c/coreboot/+/38586/2/src/superio/aspeed/ast2400/... PS2, Line 43: conf->use_espi = 1;
iirc ast2400_init gets called after enable_dev, so this won't have an effect below in enable_dev
Maybe like this?