11 Feb
2019
11 Feb
'19
8:31 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31346 )
Change subject: libpayload/sys/types.h: Add definition for off_t ......................................................................
Patch Set 1:
I don't mind adding the type, but I'm not sure why we need a whole new header file for it. Why not just throw it into stddef.h or something? I don't think libpayload ever intended to be fully POSIX-compliant in terms of which definitions are in which headers (rather, all the standard stuff is supposed to be included as some part of libpayload.h).
Also, why not define it to ssize_t?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31346
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c0c1bc1a959db7863cbad2ba29318da162431be
Gerrit-Change-Number: 31346
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Mon, 11 Feb 2019 20:31:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment