Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39374 )
Change subject: soc/{apl,glk}: set GPU based on CONFIG_ONBOARD_VGA_IS_PRIMARY
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39374/17/src/soc/intel/apollolake/c...
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/39374/17/src/soc/intel/apollolake/c...
PS17, Line 45: PRIMARY_AUTO = 0,
: PRIMARY_IGD = 2,
: PRIMARY_PCI = 3,
Ack
Uhm, this isn't solved, though. Did you see any difference in FSP behavior when choosing IGD over PCI? The only difference is that a non-zero value sets a bit in GGC to indicate that the IGD isn't the primary video adaptor.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcd117217cf412ee0722aff52db4b3c8ec2a226c
Gerrit-Change-Number: 39374
Gerrit-PatchSet: 22
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Fri, 20 Nov 2020 08:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment