[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Intel Xeon Scalable Processor support

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )

Change subject: soc/intel: Add Intel Xeon Scalable Processor support
......................................................................

Patch Set 33:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/rese... 
File src/soc/intel/xeon_sp/reset.c:

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/rese... 
PS21, Line 21: void chipset_handle_reset(uint32_t status)
             : {
             : 	switch (status) {
             : 	case FSP_STATUS_RESET_REQUIRED_5: /* Global Reset */
             : 		die("Global Reset not implemented!\n");
             : 		break;
             : 	default:
             : 		printk(BIOS_ERR, "unhandled reset type %x\n", status);
             : 		die("unknown reset type");
             : 		break;
             : 	}
             : }
> if it is unimplemented, it is fine. […]

Done

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/soc_... 
File src/soc/intel/xeon_sp/soc_util.c:

https://review.coreboot.org/c/coreboot/+/38548/21/src/soc/intel/xeon_sp/soc_... 
PS21, Line 599: 		if (total_delay >= max_delay)
> please use stopwatch_ family of functions (timer. […]

Done