Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39869 )
Change subject: payloads/seabios: Add Hardware IRQ Kconfig
......................................................................
Patch Set 4:
Patch Set 3:
Patch Set 3: Code-Review-1
Unfortunately it breaks my Braswell boards. They are running fine with SeaBIOS on current master coreboot. They do not need disabling Hardware IRQ. Please make this selection only for mainboards that affect you.
thanks for testing Michal, I Was under the impression it was a platform vs board issue. I'll adjust in the next patch set to only select for the google boards I have that need it
Let me know when you finish. I will give +2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39869
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I23e9b30d2d1042c86bd10f134d6fe361edaf8cb2
Gerrit-Change-Number: 39869
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 30 Mar 2020 08:16:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment