Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40405 )
Change subject: soc/intel/cannonlake|soc/intel/common: Add support for UARTs on PCH-H ......................................................................
Patch Set 15: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... PS15, Line 230: Double newline
https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... PS15, Line 273: fffff there's five `f`
https://review.coreboot.org/c/coreboot/+/40405/15/src/soc/intel/common/block... PS15, Line 306: switch (dev->device) { Not all cases are handled here. Is this intentional?