Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39982 )
Change subject: mb/google/glados: drop VR config from devicetree ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39982/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39982/1//COMMIT_MSG@10 PS1, Line 10: (SKL-U or SKL-Y), so drop them from the variant devicetrees.
Could you please explain where the values of the default config were compared and where they come fr […]
defaults for each domain are defined soc/intel/skylake/vr_config.c:25 and set in fill_vr_domain_config().
I compared each of the default and calculated values to those in the varaints' devicetrees. The only differences are the values of of psi3/4enable (which is mitigated by CB:39980). The icc_max values are set dynamically via get_sku_icc_max(), and will result in the same values for each domain for each SKU (SKL-U vs SKL-Y).
I can add a print function to dump the VR config values from the UPDs after they are set if needed.