Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40677 )
Change subject: soc/amd/{common,picasso}: Move GFX device from static ASL to SSDT
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
It would help to have this code build-tested
https://review.coreboot.org/c/coreboot/+/40677/2/src/soc/amd/common/block/gr...
File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/40677/2/src/soc/amd/common/block/gr...
PS2, Line 8: static void graphics_fill_ssdt(struct device *dev)
wire this up on line 26?
Indeed, it would be very nice if we actually put this function to good use somewhere! 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a967cdc43b74f786e645d3fb666506070851a99
Gerrit-Change-Number: 40677
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 23 Apr 2020 22:37:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment