Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48483 )
Change subject: [WIP] soc/amd/picasso/smi: add missing bits to GEVENT_MASK ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48483/1//COMMIT_MSG@12 PS1, Line 12: TODO: Find out if this is intentional or a bug.
I think this was either an oversight or these bits didn't exist in stoney where this code originated […]
ok, i'll remove the [WIP] tag then. the header file is in the picasso directory, so no need to #ifndef it. Quite a few defines are identical, but i'll keep the header files separate for now