Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40764 )
Change subject: src/cpu/x86/mtrr/earlymtrr: Add clear_all_var_mtrr ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40764/1/src/cpu/x86/mtrr/earlymtrr.... File src/cpu/x86/mtrr/earlymtrr.c:
https://review.coreboot.org/c/coreboot/+/40764/1/src/cpu/x86/mtrr/earlymtrr.... PS1, Line 50: int unsigned int
The compiler might then use shift when multiplying?
#define MTRR_PHYS_BASE(reg) (0x200 + 2 * (reg)) #define MTRR_PHYS_MASK(reg) (MTRR_PHYS_BASE(reg) + 1)