Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45411 )
Change subject: soc/intel/common/block: Skip saving VBNV data if ctx is NULL ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45411/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/45411/2/src/soc/intel/common/block/... PS2, Line 177: vboot_reboot I think this should happen only when we are able to save context and trigger recovery mode. If for any reason that fails, we should drop down to the die below.
Ideally, the condition that vboot context is not available should not happen and if it does, then we probably have some other critical hardware issue which probably wouldn't be fixed by rebooting. So, instead of getting stuck in a reboot loop, we can just die here. I think we might see this mostly during development/testing if it ever happens.