Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38864 )
Change subject: superio/nuvoton/nct5539d: Update documentation and remove DSDT
......................................................................
Patch Set 2: Code-Review+2
Patch Set 2:
Patch Set 2:
Patch Set 2:
Patch Set 2:
Tested, didn't go well, the system halts earlier than before. A bit lazy to create a full report but it's on the way (in few hours may be).
https://pastebin.com/wCEDmiM4
Looks like your devicetree is broken, as there are tons of "BUG: Check your devicetree!"
There's documentation how to use the SIO SSDT gen: https://doc.coreboot.org/superio/common/ssdt.html
added ssdt option to the devicetree.cb and tested, https://drive.google.com/open?id=1eyPO_tEzJdNJ_pfDYLmsZ0R-1gJVPuNg
I see no "BUG", so it works fine?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b7daeadaaac93d74ee2fc9eb18f0eff5ef50eb3
Gerrit-Change-Number: 38864
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Pavlushka
Gerrit-Comment-Date: Tue, 03 Mar 2020 22:12:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment