Attention is currently required from: Arthur Heymans, Subrata Banik, Kane Chen.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63486 )
Change subject: soc/intel/common: Enable rom cache on all CPU threads
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
ah yes, thanks for capturing this.
i miss this.
it only restores BSP MTRR.
@Arthur, can you please comment reg CB:63498
With TXT APs are shut down along the way and not started up again. I know it's a different problem that also needs a solution, but that approach would break it.
What do you think of my suggestion to add a nop call on APs, to be sure they finished setting up MTRRs and don't override that temp one. Then the temp MTRR is only set on the BSP? I generally like to avoid keeping track of the state of APs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63486
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d7ffc6e5f5ec49abf848d3cd9f0435c93f834dc
Gerrit-Change-Number: 63486
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 10:32:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur.heymans@9elements.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-MessageType: comment