Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/51931 )
Change subject: soc/amd/picasso/acpi: pass correct enum to acpigen_write_CSD_package ......................................................................
soc/amd/picasso/acpi: pass correct enum to acpigen_write_CSD_package
The coordtype parameter of acpigen_write_CSD_package expects a CSD_coord enum value, but HW_ALL that got passed as parameter is a PSD_coord enum value, so replace that with the correct CSD_HW_ALL enum value.
TEST=Timeless build results in identical binary for Mandolin.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Found-by: Paul Menzel pmenzel@molgen.mpg.de Change-Id: I90b19345b8dc6d386b6acfa81c6c072dcd6981ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/51931 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/picasso/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Raul Rangel: Looks good to me, approved
diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index d629d1c..4ec08e1 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -354,7 +354,7 @@
acpigen_write_CST_package(cstate_info, ARRAY_SIZE(cstate_info));
- acpigen_write_CSD_package(cpu >> 1, threads_per_core, HW_ALL, 0); + acpigen_write_CSD_package(cpu >> 1, threads_per_core, CSD_HW_ALL, 0);
acpigen_pop_len(); }