Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33406 )
Change subject: util/superiotool/nuvoton.c: add NCT5539D chip registers, from NCT5539D_Datasheet_V1.1(June 30th, 2015),tested on ASUS-H110M-E/M.2 mainboard. ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/33406/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33406/8//COMMIT_MSG@7 PS8, Line 7: util/superiotool/nuvoton.c: add NCT5539D chip registers, from NCT5539D_Datasheet_V1.1(June 30th, 2015),tested on ASUS-H110M-E/M.2 mainboard. Please split this into several lines, so that there is a commit summary (which does NOT end with a period '.') and a description. For instance:
util/superiotool/nuvoton.c: add NCT5539D register dump
Values taken from NCT5539D datasheet V1.1 (June 30th, 2015). Tested on ASUS-H110M-E/M.2 mainboard.
https://review.coreboot.org/#/c/33406/8/util/superiotool/nuvoton.c File util/superiotool/nuvoton.c:
https://review.coreboot.org/#/c/33406/8/util/superiotool/nuvoton.c@585 PS8, Line 585: (not all LDNs supported) Is this true, though? If you added all the LDNs in the datasheet, I would remove this part