Attention is currently required from: Felix Singer, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44740 )
Change subject: soc/intel/cnl: Allow enabling/disabling Chap device
......................................................................
Patch Set 14:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/44740/comment/356a483d_e2802469
PS13, Line 12: The purpose of this device is not clear
We might want to wait for chipset devicetrees to allow configuring the device through Kconfig. […]
If we want the dt to specify the default, we could add a Kconfig like this:
~~~
choice
prompt "Override devicetree: CHAP"
default DT_CHAP_NO_OVERRIDE
config DT_CHAP_NO_OVERRIDE
bool "use devicetree value"
config DT_CHAP_ENABLE
bool "enable"
config DT_CHAP_DISABLE
bool "disable"
endchoice
~~~
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44740
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I177c2dc91a507cc633b024cf388bcc97e0d0f2e6
Gerrit-Change-Number: 44740
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 03 May 2021 13:09:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment