Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39180 )
Change subject: mb/Kconfig: Align ROM size options ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39180/1/src/mainboard/Kconfig File src/mainboard/Kconfig:
https://review.coreboot.org/c/coreboot/+/39180/1/src/mainboard/Kconfig@148 PS1, Line 148: default 64 if COREBOOT_ROMSIZE_KB_64
How about adding the spaces before the numbers? so those are right aligned.
Sounds good, done.
https://review.coreboot.org/c/coreboot/+/39180/1/src/mainboard/Kconfig@167 PS1, Line 167: default 0x10000 if COREBOOT_ROMSIZE_KB_64
How about 0-prefixing the numbers?
Let's give it a try... Whoops! Looks like the longest numbers have seven hex digits...
Since seven-digit hex numbers are cursed (almost look like eight-digit, 32bit values), I've also zero-prefixed them.
Another reason to switch to Ada, I guess? ;^)