Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47395 )
Change subject: elog: Add new wake source codes ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@123 PS1, Line 123: #define ELOG_WAKE_SOURCE_PME_TBT 0x2d
This change will also be required in mosys.
Yep, I was waiting until these got +2'd before I pushed that change too 😊
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@124 PS1, Line 124: ELOG_WAKE_SOURCE_PME_TCSS_XHCI
Don't we need XHCI_USB_2 and XHCI_USB_3?
yep
https://review.coreboot.org/c/coreboot/+/47395/1/src/include/elog.h@126 PS1, Line 126: ELOG_WAKE_SOURCE_PME_TCSS_DMA0
Do we want to handle this like it is done for XHCI? i.e. […]
I thought about that as well... that sounds fine to me. would've been nice if we'd done that for PCIe RPs too 😉