Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32329 )
Change subject: ACPI: Clarify serial bus revision and specific revision
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32329/1/src/arch/x86/include/arch/acpi_devic...
File src/arch/x86/include/arch/acpi_device.h:
https://review.coreboot.org/#/c/32329/1/src/arch/x86/include/arch/acpi_devic...
PS1, Line 317: #define ACPI_SPI_SPECIFIC_REVISION_ID
Thank you for the review. […]
I think either one is fine
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32329
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I366f62e6aa0e9c0dfbc1ec17adeebc42a0e777eb
Gerrit-Change-Number: 32329
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 16:38:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment