Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30559 )
Change subject: drivers/spi: Add controller protection type
......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/30559/9/src/include/spi_flash.h
File src/include/spi_flash.h:
https://review.coreboot.org/#/c/30559/9/src/include/spi_flash.h@211
PS9, Line 211: enum ctrlr_prot_type type);
you could make it const enum
Done
https://review.coreboot.org/#/c/30559/9/src/soc/intel/broadwell/spi.c
File src/soc/intel/broadwell/spi.c:
https://review.coreboot.org/#/c/30559/9/src/soc/intel/broadwell/spi.c@619
PS9, Line 619: enum ctrlr_prot_type type)
alignment
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30559
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I093884c4768b08a378f21242ac82e430ac013d15
Gerrit-Change-Number: 30559
Gerrit-PatchSet: 11
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Jan 2019 13:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment