Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41667 )
Change subject: AGESA f14/f15tn/f16kb: Clean up buildOpts.c files ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Config/PlatformInstall.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 860: CStateModeDisabled Is this a better default? In my experience, both CStateModeC6 and CStateModeDisabled are working
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... File src/vendorcode/amd/agesa/f16kb/Proc/CPU/cpuLateInit.h:
https://review.coreboot.org/c/coreboot/+/41667/6/src/vendorcode/amd/agesa/f1... PS6, Line 232: SCOPE_NAME_P What does it mean - these changes from SCOPE_NAME_C to SCOPE_NAME_P ?