build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28606 )
Change subject: WIP: Port libpayload to riscv ......................................................................
Patch Set 7:
(42 comments)
https://review.coreboot.org/#/c/28606/7/payloads/external/LinuxBoot/Makefile File payloads/external/LinuxBoot/Makefile:
https://review.coreboot.org/#/c/28606/7/payloads/external/LinuxBoot/Makefile... PS7, Line 78: echo "BEFOR DEF" 'BEFOR' may be misspelled - perhaps 'BEFORE'?
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/arch/riscv/coreb... File payloads/libpayload/arch/riscv/coreboot.c:
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/arch/riscv/coreb... PS7, Line 43: switch(rec->tag) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/asm.h:
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 14: #define ALIGN .align 2 Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 16: #define ENDPROC(name) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 17: .type name, %function; \ need consistent spacing around '%' (ctx:WxV)
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 20: #define ENTRY(name) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 21: .section .text.name, "ax", %progbits; \ need consistent spacing around '%' (ctx:WxV)
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 24: name: labels should not be indented
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 26: #define END(name) \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 27: .size name, .-name space required before that '-' (ctx:VxV)
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/barrier.h:
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 57: #define mb() memory barrier without comment
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 58: #define rmb() memory barrier without comment
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 59: #define wmb() memory barrier without comment
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... File payloads/libpayload/include/riscv/arch/cache.h:
https://review.coreboot.org/#/c/28606/7/payloads/libpayload/include/riscv/ar... PS7, Line 81: } void function return statements are not generally useful
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/linuxcheck.c File payloads/linuxcheck/linuxcheck.c:
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/linuxcheck.c@27 PS7, Line 27: buts("Greetings from linuxcheck, via hard-coded calls to serial functions.\r\n"); line over 80 characters
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/linuxcheck.c@31 PS7, Line 31: buts("Bad news: lib_sysinfo.serial is NULL. Very little will work well.\r\n"); line over 80 characters
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/linuxcheck.c@41 PS7, Line 41: buts("If you did not see puts works, then you have a console issues\r\n"); line over 80 characters
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/linuxcheck.c@44 PS7, Line 44: buts(" ... if you did not see printf works, then you have a printf issue\r\n"); line over 80 characters
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c File payloads/linuxcheck/riscv-fu540.c:
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@25 PS7, Line 25: uint32_t txdata; /* Transmit data register */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@25 PS7, Line 25: uint32_t txdata; /* Transmit data register */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@26 PS7, Line 26: uint32_t rxdata; /* Receive data register */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@26 PS7, Line 26: uint32_t rxdata; /* Receive data register */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@27 PS7, Line 27: uint32_t txctrl; /* Transmit control register */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@27 PS7, Line 27: uint32_t txctrl; /* Transmit control register */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@28 PS7, Line 28: uint32_t rxctrl; /* Receive control register */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@28 PS7, Line 28: uint32_t rxctrl; /* Receive control register */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@29 PS7, Line 29: uint32_t ie; /* UART interrupt enable */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@29 PS7, Line 29: uint32_t ie; /* UART interrupt enable */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@30 PS7, Line 30: uint32_t ip; /* UART interrupt pending */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@30 PS7, Line 30: uint32_t ip; /* UART interrupt pending */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@31 PS7, Line 31: uint32_t div; /* Baud rate divisor */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@31 PS7, Line 31: uint32_t div; /* Baud rate divisor */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@36 PS7, Line 36: return !(read32(®s->txdata) & TXDATA_FULL); code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@36 PS7, Line 36: return !(read32(®s->txdata) & TXDATA_FULL); please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@41 PS7, Line 41: struct sifive_uart_registers *regs = (void *)(FU540_UART(idx)); code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@41 PS7, Line 41: struct sifive_uart_registers *regs = (void *)(FU540_UART(idx)); please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@43 PS7, Line 43: while (!uart_can_tx(regs)) code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@43 PS7, Line 43: while (!uart_can_tx(regs)) please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@44 PS7, Line 44: ; /* TODO: implement a timeout */ code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@44 PS7, Line 44: ; /* TODO: implement a timeout */ please, no spaces at the start of a line
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@46 PS7, Line 46: write32(®s->txdata, data); code indent should use tabs where possible
https://review.coreboot.org/#/c/28606/7/payloads/linuxcheck/riscv-fu540.c@46 PS7, Line 46: write32(®s->txdata, data); please, no spaces at the start of a line