Attention is currently required from: Ravi kumar, mturney mturney, Furquan Shaikh, Kyösti Mälkki, Prasad Malisetty.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57614 )
Change subject: libpayload: Export PCIe config info from coreboot to libpayload
......................................................................
Patch Set 37:
(1 comment)
File src/lib/coreboot_table.c:
https://review.coreboot.org/c/coreboot/+/57614/comment/d2413970_a6761e04
PS37, Line 106: pci_info->config_base = CONFIG_MMIO_BASE_ADDRESS;
: pci_info->atu_base = CONFIG_MMIO_PCI_ATU_BASE;
: pci_info->config_size = CONFIG_MMIO_LENGTH;
: }
These are undefined. You need to move https://review.coreboot.org/c/coreboot/+/61773/ ahead of this CL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ca2be55b98c8d1b86576072078cdda02ac55940
Gerrit-Change-Number: 57614
Gerrit-PatchSet: 37
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 22:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment