3 Jan
2023
3 Jan
'23
6:15 p.m.
Attention is currently required from: Raul Rangel, Jason Nien, Chris Wang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71277 )
Change subject: mb/google/skyrim/var/winterhold: Enable RTD3 support for eMMC as NVMe ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/71277/comment/a73537a1_2fb2d956 PS1, Line 105: NVME
Should this be changed to EMMC?
We can do that in a follow-on patch if desired. Since this was boot tested, I have no objections to leaving it the way it is for now.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71277
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie6af4287057c6befa0b787ac28d7898166401b29
Gerrit-Change-Number: 71277
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jason Nien jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 Jan 2023 18:15:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Martin Roth martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment