[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )

Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL
......................................................................

Patch Set 13:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48286/13/src/soc/intel/common/block... 
File src/soc/intel/common/block/cpu/car/exit_car.S:

https://review.coreboot.org/c/coreboot/+/48286/13/src/soc/intel/common/block... 
PS13, Line 99:
> Sorry I looked at the "CONFIG(INTEL_CAR_CQOS)" code section for teardown. […]

I agree, I think it's safest to just recalculate the available ways. Also since most of this is "straight-line" assembly, i.e., not much in the way of subroutines, etc. I would just crib the code from the cache_as_ram.S, adjusting register usage as need be .