Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47509 )
Change subject: mb/ocp/deltalake: Define SMBIOS type 16 error correction type by RasModesEnabled
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47509/2/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47509/2/src/mainboard/ocp/deltalake...
PS2, Line 34: #define STAT_VIRT_LOCKSTEP BIT7
These definitions come from FSP. They should be added to HOB header file.
Done. Have moved these definitions to CB:47505. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3636fcc4a874261cf484c10e2db15015ac5d7e68
Gerrit-Change-Number: 47509
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 13 Nov 2020 05:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment