Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38540 )
Change subject: ec/google/chromeec: Add new wrappers for host commands
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38540/7/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/38540/7/src/ec/google/chromeec/ec.c...
PS7, Line 1424: int
Why not make it unsigned?
The API for this file is to return negative values on error (usually -1), and 0 for success, while any "returned values" are returned through out arguments, so I'm just keeping it consistent here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57edbe1592cd28b005f01679ef8a8b5de3e1f586
Gerrit-Change-Number: 38540
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 16:08:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment