Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40252 )
Change subject: mb/google/hatch: Allow variants to not necessarily be laptops ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 25: select SYSTEM_TYPE_LAPTOP
It might be worth gating this too.
yep fair enough, that would change the behavior of the FACP table construction in the ASL. Can you verify the kernel is happy with the implications? N.B., acpi_create_fadt()
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 140: VBOOT_LID_SWITCH
This probably should be gated by BOARD_GOOGLE_BASEBOARD_HATCH_LAPTOP.
Done. Just note the verstage implication here is that: if (CONFIG(VBOOT_LID_SWITCH) && !get_lid_switch()) ctx->flags |= VB2_CONTEXT_NOFAIL_BOOT;
https://review.coreboot.org/c/coreboot/+/40252/1/src/mainboard/google/hatch/... PS1, Line 147: select VBOOT_EARLY_EC_SYNC
instead of the if... endif you could also just change the above to […]
I guess we will be gating more here hence the structure is more generalised.