Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37822 )
Change subject: mainboard/google/puff: Don't enable MAX98357A in dt ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/puff/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 147: device pci 1f.3 on
perhaps it would be cleaner to move this out of the baseboard and into the other variants?
I agree.
https://review.coreboot.org/c/coreboot/+/37822/3/src/mainboard/google/hatch/... PS3, Line 151: # the children and so we must force the childs driver to
'childs' may be misspelled - perhaps 'children'?
Ack