Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35960 )
Change subject: libpayload: Add uart/serial driver support for trogdor ......................................................................
Patch Set 35:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... File payloads/libpayload/drivers/serial/qcom_qupv3_serial.c:
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... PS35, Line 314: if (data == 0xa)
Why is this data special?
This is a newline... if you look through the serial drivers, you can see that pretty much all of them insert carriage returns in front of newlines (because that's what you need to make it look right on a serial terminal). We could write '\r' and '\n' instead of 0xa and 0xd here to make that more obvious.
https://review.coreboot.org/c/coreboot/+/35960/35/payloads/libpayload/driver... PS35, Line 316: uart_qupv3_tx_byte(data);
If you want: […]
That is not what this does, there's no 'else' up there. If the character is a newline it will print a carriage return in front of it, but it will still print the newline as well.