Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34894 )
Change subject: soc/intel: Move fill_postcar_frame to memmap.c ......................................................................
Patch Set 1:
Patch Set 1:
Do you see this code working ? when we tries to run marking postcar region as cache WB?
refer the comments here https://review.coreboot.org/c/coreboot/+/34805 We are working to make this work (yesterday Patrick R helped to run on his KBL machine, last 3 days me and Aaron are debugging this issue). recommend you to follow this CL and share your opinion rather just trying to do duplicate stuff.
This is orthogonal work to keep some consistency across platforms, wrt. where certain functions are implemented. At the end of the day this will help you create the API you need to apply WB/WT/WC MTRRs at end of romstage, should you find a stable solution for the skip-postcar approach.