Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29969 )
Change subject: TEMP: NOT FOR REVIEW: qcs405: memlayout: Make bootblock 64k aligned ......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/#/c/29969/21//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29969/21//COMMIT_MSG@9 PS21, Line 9: excepts that expects the
https://review.coreboot.org/#/c/29969/21/src/arch/arm64/armv8/bootblock.S File src/arch/arm64/armv8/bootblock.S:
https://review.coreboot.org/#/c/29969/21/src/arch/arm64/armv8/bootblock.S@26 PS21, Line 26: ldr x15, =arm64_init_cpu : blr x15 what is this change about?
https://review.coreboot.org/#/c/29969/21/src/soc/qualcomm/qcs405/include/soc... File src/soc/qualcomm/qcs405/include/soc/memlayout.ld:
https://review.coreboot.org/#/c/29969/21/src/soc/qualcomm/qcs405/include/soc... PS21, Line 36: 0x8C3a000 generally we tend to use lower case, but since everything else in this file is using upper case, please keep things consistent.