Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32367 )
Change subject: mb/google/sarien: Fix s5 touchscreen power leakage
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants...
PS4, Line 21: 5
S3 is not a POR on both sarien and arcada.
S3 still need to be working as fail safe option?
https://review.coreboot.org/#/c/32367/4/src/mainboard/google/sarien/variants...
PS4, Line 23: CTXS (TS_PD)
Won't you be violating the power down specification by not asserting reset before disabling power?
@Roy, would you like to answer here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32367
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4229477b7149c0a75f4a8c6c7c453a37cc1c78c
Gerrit-Change-Number: 32367
Gerrit-PatchSet: 5
Gerrit-Owner: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Apr 2019 18:21:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Roy Mingi Park
roy.mingi.park@intel.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment