Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46840 )
Change subject: soc/amd/picasso: Update coreboot UPD variable names to include units
......................................................................
Patch Set 6: Code-Review+1
I'd prefer _s instead of _sec for consistency and SI unit reasons
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I056a76663e84ebc940343d64178c18cb20df01a3
Gerrit-Change-Number: 46840
Gerrit-PatchSet: 6
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Oct 2020 13:02:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment