Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39599 )
Change subject: nb/intel/sandybridge: Tidy up code and comments
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/raminit_ivy.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy...
PS2, Line 389: }
I think it will make Jenkins complain, though. […]
yeah, rewriting this as a switch case statement would be nice. not sure if that changes the binary; if so, just do that in a follow-up patch. same for that construct in raminit_sandybridge.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e113e48afd685ca63cfcb11ff9fcf9df6e41e46
Gerrit-Change-Number: 39599
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Mar 2020 13:25:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment