[coreboot-gerrit] [M] Change in coreboot[main]: mb/google/{brya,hades}: use soc index for variant_update_power_limits()

[Sumeet R Pawnikar (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim, Subrata Banik.

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81436?usp=email )

Change subject: mb/google/{brya,hades}: use soc index for variant_update_power_limits()
......................................................................

Patch Set 5:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/81436/comment/785acea0_7a097c28 :
PS5, Line 13: override the PL4 value
Please share more details on the reason for overriding the PL4 value.

AFAIK user space overrides only PL1/PL2. There is no specific requirement/need for overriding PL4 value from user space.

File src/mainboard/google/brya/variants/baseboard/brya/ramstage.c:

https://review.coreboot.org/c/coreboot/+/81436/comment/7f5c5902_d407d8f5 :
PS5, Line 39: 			   
Any reason to removal of these? It was aligned based on the previous argument.

https://review.coreboot.org/c/coreboot/+/81436/comment/55c0a9ba_d0e95a73 :
PS5, Line 41: 	
same comment as above.

https://review.coreboot.org/c/coreboot/+/81436/comment/3747a278_e79e4bcb :
PS5, Line 68: 			soc_config->tdp_pl4 = DIV_ROUND_UP(limits[i].pl4_power,
> > The override table has PL1/PL2 min/max values. […]

DPTF (user space service) overrides PL1/PL2 for MMIO registers only.