build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36518 )
Change subject: trogdor: QCSDI loading depends on VB2_GBB_FLAG_FAFT_KEY_OVERIDE setting ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... PS1, Line 162: if(!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) { 'OVERIDE' may be misspelled - perhaps 'OVERRIDE'?
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... PS1, Line 162: if(!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) { trailing whitespace
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... PS1, Line 162: if(!(gbb_is_flag_set(VB2_GBB_FLAG_FAFT_KEY_OVERIDE))) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... PS1, Line 163: struct prog qcsdi = trailing whitespace
https://review.coreboot.org/c/coreboot/+/36518/1/src/soc/qualcomm/common/qcl... PS1, Line 164: PROG_INIT(PROG_REFCODE, trailing whitespace