2 Apr
2019
2 Apr
'19
2:54 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32134 )
Change subject: mb/google/hatch: Enable Goodix Touch Screen ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 248: 100
datasheet is > 10ms
Then, why choose 100? This will affect the boot time as well as resume time.
https://review.coreboot.org/#/c/32134/6/src/mainboard/google/hatch/variants/... PS6, Line 249: 5
datasheet is > 1ms
Then why choose 5?
--
To view, visit https://review.coreboot.org/c/coreboot/+/32134
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib204e6b77b87ba6c775cf38e572476dd9eb37d1d
Gerrit-Change-Number: 32134
Gerrit-PatchSet: 6
Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Tue, 02 Apr 2019 02:54:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment