13 Oct
2020
13 Oct
'20
12:43 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45971 )
Change subject: superio/nuvoton/nct6779d: Add symbol to select COM port ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... File src/superio/nuvoton/common/early_serial.c:
https://review.coreboot.org/c/coreboot/+/45971/4/src/superio/nuvoton/common/... PS4, Line 57: CONFIG(SUPERIO_NUVOTON_NCT6779D_COM_A)) For the future, we could just have a single Kconfig, reflecting what it does, e.g.
config SUPERIO_NUVOTON_COM_A_2A_7
--
To view, visit https://review.coreboot.org/c/coreboot/+/45971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I024ea86634b489985112ddb7ce07886e412e4c0b
Gerrit-Change-Number: 45971
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 22:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment