Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37456 )
Change subject: mb/google/octopus: Create Foob variant
......................................................................
Patch Set 4:
Patch Set 1:
(7 comments)
Dear Henry,
I just modify the code that related to SKU ID, eventually, I confirmed with our EE, foob cooreboot section leverage to phaser is fine.
So:
1. devicetree need not modificatoin
2. default GPIO setting is fine
3. remove mainboard.c and variant.c, which related to SKU IDs.
Thanks and best regards
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37456
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcdda4dd0846612f5e98ab454db7144c1caf0507
Gerrit-Change-Number: 37456
Gerrit-PatchSet: 4
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Dec 2019 03:58:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment